Update MSBuildLocator to include Pre Release#7508
Merged
jonpryor merged 5 commits intodotnet:mainfrom Nov 8, 2022
Merged
Conversation
jonathanpeppers
approved these changes
Nov 2, 2022
dellis1972
force-pushed
the
devbox
branch
2 times, most recently
from
618c76b to
0304647
Compare
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 9, 2022
* main: [build] Make external build targets more consistent (dotnet#7536) [ci] Rename the yaml-templates resource Bump to xamarin/Java.Interop/main@c6c487b (dotnet#7543) [vswhere] Update MSBuildLocator to support -prerelease (dotnet#7508) [build-tools] Update UpdateApkSizeReference scripts to use net7 path (dotnet#7512)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DevBox system only installs pre-release versions of VS. So we need to pass the
-prereleaseswitch tovswhere.exein order to find the installations.Currently the
MSBuildLocatordoes not include this switch. This is for a good reason in that we want to use stablereleases when possible for our CI builds. However in certain environments like DevBox we DO want to use pre release.
So as part of the process if we don't detect a stable release first, we should fallback to a prerelease verison.